[ci] E: Update nanvix workflow refs to v2.3.0#103
Merged
Conversation
workflows@v2.3.0 downloads the windows-test artifact into test_out(), so _run_tests_windows must look there. Replaces the FileExistsError clobber-guard with the same preexisted-gate used in the sibling repos.
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Nanvix CI integration by bumping the reusable workflow reference to nanvix/workflows@v2.3.0, and it also includes a functional change to the Windows test runner in .nanvix/z.py related to where test binaries are discovered and how they are staged for make_initrd.
Changes:
- Bump
.github/workflows/nanvix-ci.ymlreusable workflow refs fromv2.2.0tov2.3.0. - Update Windows test binary discovery to also scan
test_out()(artifact overlay) first. - Adjust repo-root ELF staging behavior for Windows tests (but current logic risks overwriting an existing repo-root binary).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .nanvix/z.py | Changes Windows test discovery/staging logic (including adding test_out() as a search location). |
| .github/workflows/nanvix-ci.yml | Bumps reusable workflow refs to nanvix/workflows@v2.3.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
316
to
+320
| if binary.resolve() != repo_elf.resolve(): | ||
| if repo_elf.exists(): | ||
| raise FileExistsError( | ||
| f"refusing to clobber existing {repo_elf}" | ||
| ) | ||
| # Don't clobber a dev's prior repo-root build. | ||
| preexisted = repo_elf.exists() | ||
| shutil.copy2(binary, repo_elf) | ||
| copied_elf = True | ||
| copied_elf = not preexisted |
Comment on lines
+287
to
289
| # test_out() is the windows-test artifact overlay. | ||
| for candidate in [test_out(), repo_root(), repo_root() / "build"]: | ||
| if candidate.is_dir(): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated bump of
nanvix/workflowsreferences tov2.3.0.Generated by the Update Workflow Refs workflow.